Merged
Conversation
dknopik
added
bug
jking-aus
approved these changes
Mar 18, 2025
Member
jking-aus
left a comment
jking-aus
left a comment
There was a problem hiding this comment.
good job mate -- I just added a todo for when we come back and fix this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The inner
QbftMessagehas a fieldidentifier, which contains the message id. The message id is also contained in the outerSsvMessage.As this is repeated, we used our type
MessageIdin both places, but the types actually differ, even though they contain the same data in every message:https://github.com/ssvlabs/ssv-spec/blob/36c660085fd74464dcfd301a0084e1112ed264ea/qbft/messages.go#L51 vs https://github.com/ssvlabs/ssv-spec/blob/4066ef02de3c159ea9852bc5615358ca03384fba/types/messages.go#L96
We fail to decode the inner
QbftMessage, as the field is taggedssz-max, which indicates that this is a variable length field. This is encoded differently in SSZ vs a fixed sized field.Solution
As the inner identifier is redundant anyway, don't bother with our custom type, and treat it as an opaque variable sized byte list with max length of 56. We still ensure that it is identical to the outer identifier.